Spark - Fix flaky time dependent test in remove orphan files#4859
Merged
rdblue merged 1 commit intoapache:masterfrom May 27, 2022
Merged
Spark - Fix flaky time dependent test in remove orphan files#4859rdblue merged 1 commit intoapache:masterfrom
rdblue merged 1 commit intoapache:masterfrom
Conversation
kbendick
force-pushed
the
kb-fix-flakey-remove-orphan-files
branch
from
eb387fa to
27f8b2d
Compare
| DeleteOrphanFiles.Result result = SparkActions.get().deleteOrphanFiles(table) | ||
| .executeDeleteWith(executorService) | ||
| .olderThan(System.currentTimeMillis()) | ||
| .olderThan(System.currentTimeMillis() + 5000) // Ensure all orphan files are selected |
Member
There was a problem hiding this comment.
Where we are going, we don't need roads.
RussellSpitzer
approved these changes
May 25, 2022
singhpk234
approved these changes
May 25, 2022
amogh-jahagirdar
approved these changes
May 27, 2022
Contributor
|
Thanks, @kbendick! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes issue #4856
We have observed this test causing CI to fail due to timestamp precision issues (and time being relative).
Instead of adding additional busy waiting (and extending CI time), this PR updates the creation time that orphan files need to be older than 5 seconds into the future, to ensure that all orphan files are removed even if some of them wind up with a timestamp that's somewhat wonky due to timestamp precision issues.
This should ensure that all files are written with timestamps prior to the
olderThantimestamp.cc @RussellSpitzer @singhpk234